-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(generator): allow passing builder
to getGenerator
#9574
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #9574 +/- ##
==========================================
- Coverage 65.15% 65.14% -0.02%
==========================================
Files 94 94
Lines 4107 4108 +1
Branches 1126 1126
==========================================
Hits 2676 2676
- Misses 1152 1153 +1
Partials 279 279
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Thanks for notice and PR @mrazauskas. To avoid cycling dependency between generator and builder, what do you think if:
|
builder
to getGenerator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Types of changes
Description
It seems like constructor of
Generator
class has to receive two arguments (nuxt
andbuilder
). CurrentlygetGenerate
helper is passing onlynuxt
to the class. Therefor callinggetGenerate(nuxt)
throws 'TypeError: Cannot read property 'forGenerate' of undefined...'. It originates from this line, becausethis.builder
is undefined.Checklist:
getGenerate
is rather minor and obvious function. I can’t spot it in the test suite. Hope it is acceptable to keep it untested.